[PATCH] D32319: Add constrained intrinsics for some libm-equivalent operations

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: docs/LangRef.rst:13313
+described, not determined, by the rounding mode argument.  The actual rounding
+mode is determined by the runtime floating point environemtn.  The rounding
+mode argument is only intended as information to the compiler.
----------------
environment is misspelled.


================
Comment at: docs/LangRef.rst:13353
+described, not determined, by the rounding mode argument.  The actual rounding
+mode is determined by the runtime floating point environemtn.  The rounding
+mode argument is only intended as information to the compiler.
----------------
environment is misspelled


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:6551
+  default: 
+    llvm_unreachable("MutateStrictFPToFP called with unexpected opcode!");
+  case ISD::STRICT_FADD: NewOpc = ISD::FADD; break;
----------------
Lowercase mutate to match the function name?


Repository:
  rL LLVM

https://reviews.llvm.org/D32319