[PATCH] D30107: Refactor DynamicLibrary so searching for a symbol will have a defined order and libraries are properly unloaded when llvm_shutdown is called.

Frederich Munch via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 24 14:32:55 PDT 2017


marsupial added a comment.

> You should test it with ROOT, there we do a `dlopen(libcling, RTLD_LAZY|RTLD_LOCAL)` and I think there the symbol resolution doesn't work as before.

RTLD_LOCAL means any symbols loaded will not be available for lookup.
If you are relying on symbol lookup via a process handle [ **dlsym(dlopen(NULL, Flags), "Symbol")** ] then you need to use RTLD_GLOBAL.

> It seems that the test coverage is low.

Add as many more as you can.


Repository:
  rL LLVM

https://reviews.llvm.org/D30107





More information about the llvm-commits mailing list