[PATCH] D32779: DWARF: Implementation of v5 string offsets table (.debug_str_offsets[.dwo] section)/consumer

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp updated this revision to Diff 100144.
wolfgangp added a comment.

1. Added tests for invalid formatting of the string offsets section (hand-constructed DWARF).
2. Fixed a bug found with handling of dwp files and added a hand-constructed test for it.
3. Addressed review comments: a) rewrote validation of string offset table contribution headers b) moved mapping of debug section names to after stripping of leading _ or .
4. Using the word 'contribution' instead of 'segment' when displaying the string offsets table.


https://reviews.llvm.org/D32779

Files:
  include/llvm/DebugInfo/DIContext.h
  include/llvm/DebugInfo/DWARF/DWARFCompileUnit.h
  include/llvm/DebugInfo/DWARF/DWARFContext.h
  include/llvm/DebugInfo/DWARF/DWARFTypeUnit.h
  include/llvm/DebugInfo/DWARF/DWARFUnit.h
  include/llvm/MC/MCObjectFileInfo.h
  include/llvm/Object/MachO.h
  include/llvm/Object/ObjectFile.h
  lib/DebugInfo/DWARF/DWARFContext.cpp
  lib/DebugInfo/DWARF/DWARFFormValue.cpp
  lib/DebugInfo/DWARF/DWARFUnit.cpp
  lib/MC/MCObjectFileInfo.cpp
  lib/Object/MachOObjectFile.cpp
  test/DebugInfo/Inputs/dwarfdump-str-offsets-dwp.s
  test/DebugInfo/Inputs/dwarfdump-str-offsets-dwp.x86_64.o
  test/DebugInfo/Inputs/dwarfdump-str-offsets-invalid-1.s
  test/DebugInfo/Inputs/dwarfdump-str-offsets-invalid-1.x86_64.o
  test/DebugInfo/Inputs/dwarfdump-str-offsets-invalid-2.s
  test/DebugInfo/Inputs/dwarfdump-str-offsets-invalid-2.x86_64.o
  test/DebugInfo/Inputs/dwarfdump-str-offsets-invalid-3.s
  test/DebugInfo/Inputs/dwarfdump-str-offsets-invalid-3.x86_64.o
  test/DebugInfo/Inputs/dwarfdump-str-offsets-invalid-4.s
  test/DebugInfo/Inputs/dwarfdump-str-offsets-invalid-4.x86_64.o
  test/DebugInfo/Inputs/dwarfdump-str-offsets.s
  test/DebugInfo/Inputs/dwarfdump-str-offsets.x86_64.o
  test/DebugInfo/dwarfdump-str-offsets-invalid.test
  test/DebugInfo/dwarfdump-str-offsets.test
  tools/llvm-dwarfdump/llvm-dwarfdump.cpp
  tools/obj2yaml/dwarf2yaml.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32779.100144.patch
Type: text/x-patch
Size: 57770 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170524/beda6e87/attachment.bin>