[PATCH] D33475: [pdb] pad source file name buffer at the end instead of the beginning

Bob Haarman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 24 11:47:34 PDT 2017


inglorion added a comment.

Actually, I think there is a way to verify that the alignment is correct. If I generate a PDB from YAML using the old code (without this change) and dump it with llvm-pdbdump pretty -all, I get corrupted filenames. If I apply this change, generate the PDB from YAML again, and dump with llvm-pdbdump pretty -all, the filenames are correct. Since pretty uses the DIA library, I think that proves that the change I've implemented here expresses the correct behavior.


https://reviews.llvm.org/D33475





More information about the llvm-commits mailing list