[PATCH] D33480: [CodeView Type Merging] Try hard not to deserialize records when re-writing type indices

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 24 11:33:57 PDT 2017


rnk added inline comments.


================
Comment at: llvm/lib/DebugInfo/CodeView/TypeSerializer.cpp:71
 
+  bool ShouldHash;
+
----------------
There's no point in a type hasher that shouldn't hash. If we're not going to hash, let's just skip creation of TypeHasher. We can move SeenRecords back up to TypeSerializer. I only put it on TypeHasher so I wouldn't have to return if the value was inserted or not, but we might as well do that now.


https://reviews.llvm.org/D33480





More information about the llvm-commits mailing list