[PATCH] D33320: [SLP] Improve comments and naming of functions/variables/members, NFC.
Adam Nemet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 24 10:20:07 PDT 2017
anemet added inline comments.
================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:4824-4825
+ // vectorization is not possible or not effective, and currently analyzed
+ // instruction is a binary operation, try to vectorize the operands, using DFS
+ // traversal order. If the operands were not vectorized, repeat the same
+ // procedure considering each operand as a possible root of the horizontal
----------------
ABataev wrote:
> anemet wrote:
> > ABataev wrote:
> > > anemet wrote:
> > > > Again, which order?
> > > DFS
> > pre/in/post?
> pre
Okay, then please update the comment. Also please answer my question below why we chose to track the edges with an iterative pre-order traversal. If it's unnecessary, please fix or add a FIXME. Thank you.
https://reviews.llvm.org/D33320
More information about the llvm-commits
mailing list