[PATCH] D33473: [InstSimplify] Simplify uadd/sadd/umul/smul with overflow intrinsics when the Zero or Undef is on the LHS.

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 24 08:25:20 PDT 2017


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM.

I acknowledge that there are concerns about division-of-labor between InstSimplify and InstCombine as well as the combination of those two with other passes (see current llvm-dev threads about compile-time), but handling commuted variants of existing patterns is always good (makes the pass behavior more consistent) and cheap (if it's not, then that's an independent problem).


https://reviews.llvm.org/D33473





More information about the llvm-commits mailing list