[PATCH] D33287: [Linker] Remove warning when linking ARM and Thumb IR modules.
Teresa Johnson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 24 08:18:46 PDT 2017
tejohnson added inline comments.
================
Comment at: lib/Support/Triple.cpp:1482
+ getVendor() == Other.getVendor() && getOS() == Other.getOS();
+ else
+ return getSubArch() == Other.getSubArch() &&
----------------
Formatting seems off - can you run clang-format?
================
Comment at: lib/Support/Triple.cpp:1486
+ getEnvironment() == Other.getEnvironment() &&
+ getObjectFormat() == Other.getObjectFormat();
+
----------------
What happens if the above 2 checks are run for Apple?
https://reviews.llvm.org/D33287
More information about the llvm-commits
mailing list