[PATCH] D33225: [PowerPC] Fix a performance bug for PPC::XXSLDWI.

[Eric Christopher via Phabricator via llvm-commits]

echristo accepted this revision.
echristo added a comment.

I have one inline comment here, but it can be addressed in a follow up patch.

Thanks!

-eric



================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:1668
+bool PPC::isXXSLDWIShuffleMask(ShuffleVectorSDNode *N, unsigned &ShiftElts,
+                               bool &Swap, bool IsLE) {
+  if (N->getValueType(0) != MVT::v16i8)
----------------
I'd like to try to pull out the bool operands from these routines. If not in this patch, but in a follow up patch if possible.


https://reviews.llvm.org/D33225