[llvm] r303701 - Fixes for tests for r303698

[Kostya Serebryany via llvm-commits]

Let's try it as a single patch, but please do test on linux (or enable all
relevant tests on Mac)

On Tue, May 23, 2017 at 5:33 PM, George Karpenkov <ekarpenkov at apple.com>
wrote:

> Kostya,
>
> Everything works for me if I enable https://reviews.llvm.org/D33472
>
> Why not just use it? The optimization is very obvious, and it does cover
> many cases.
>
> On May 23, 2017, at 5:26 PM, Kostya Serebryany <kcc at google.com> wrote:
>
> Please revert this and the previous patch -- the bots are too red.
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/2055
> Then, let's figure out a way forward.
>
> On Tue, May 23, 2017 at 5:19 PM, Kostya Serebryany <kcc at google.com> wrote:
>
>> Did you test on Linux?
>> There are some related tests that have e.g. "UNSUPPORTED: i386-darwin"
>>
>> On Tue, May 23, 2017 at 3:42 PM, George Karpenkov via llvm-commits <
>> llvm-commits at lists.llvm.org> wrote:
>>
>>> Author: george.karpenkov
>>> Date: Tue May 23 17:42:34 2017
>>> New Revision: 303701
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=303701&view=rev
>>> Log:
>>> Fixes for tests for r303698
>>>
>>> Modified:
>>>     llvm/trunk/test/Instrumentation/SanitizerCoverage/coverage.ll
>>>     llvm/trunk/test/Instrumentation/SanitizerCoverage/tracing.ll
>>>
>>> Modified: llvm/trunk/test/Instrumentation/SanitizerCoverage/coverage.ll
>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Instrume
>>> ntation/SanitizerCoverage/coverage.ll?rev=303701&r1=303700&
>>> r2=303701&view=diff
>>> ============================================================
>>> ==================
>>> --- llvm/trunk/test/Instrumentation/SanitizerCoverage/coverage.ll
>>> (original)
>>> +++ llvm/trunk/test/Instrumentation/SanitizerCoverage/coverage.ll Tue
>>> May 23 17:42:34 2017
>>> @@ -54,7 +54,7 @@ entry:
>>>  ; CHECK_WITH_CHECK: ret void
>>>  ; CHECK_WITH_CHECK-LABEL: define internal void @sancov.module_ctor
>>>  ; CHECK_WITH_CHECK-NOT: ret
>>> -; CHECK_WITH_CHECK: call void @__sanitizer_cov_module_init({{.*}}, i64
>>> 3,
>>> +; CHECK_WITH_CHECK: call void @__sanitizer_cov_module_init({{.*}}, i64
>>> 4,
>>>  ; CHECK_WITH_CHECK: ret
>>>
>>>  ; CHECK2-LABEL: define void @foo
>>> @@ -68,7 +68,7 @@ entry:
>>>
>>>  ; CHECK2-LABEL: define internal void @sancov.module_ctor
>>>  ; CHECK2-NOT: ret
>>> -; CHECK2: call void @__sanitizer_cov_module_init({{.*}}, i64 3,
>>> +; CHECK2: call void @__sanitizer_cov_module_init({{.*}}, i64 4,
>>>  ; CHECK2: ret
>>>
>>>  ; CHECK3-LABEL: define void @foo
>>> @@ -76,6 +76,7 @@ entry:
>>>  ; CHECK3: call void @__sanitizer_cov
>>>  ; CHECK3-NOT: ret void
>>>  ; CHECK3: call void @__sanitizer_cov
>>> +; CHECK3: call void @__sanitizer_cov
>>>  ; CHECK3-NOT: call void @__sanitizer_cov
>>>  ; CHECK3: ret void
>>>
>>> @@ -111,5 +112,6 @@ entry:
>>>  ; CHECKPRUNE: call void @__sanitizer_cov
>>>  ; CHECKPRUNE: call void @__sanitizer_cov
>>>  ; CHECKPRUNE: call void @__sanitizer_cov
>>> +; CHECKPRUNE: call void @__sanitizer_cov
>>>  ; CHECKPRUNE-NOT: call void @__sanitizer_cov
>>>  ; CHECKPRUNE: ret void
>>>
>>> Modified: llvm/trunk/test/Instrumentation/SanitizerCoverage/tracing.ll
>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Instrume
>>> ntation/SanitizerCoverage/tracing.ll?rev=303701&r1=303700&
>>> r2=303701&view=diff
>>> ============================================================
>>> ==================
>>> --- llvm/trunk/test/Instrumentation/SanitizerCoverage/tracing.ll
>>> (original)
>>> +++ llvm/trunk/test/Instrumentation/SanitizerCoverage/tracing.ll Tue
>>> May 23 17:42:34 2017
>>> @@ -22,6 +22,7 @@ entry:
>>>  ; CHECK_PC: call void @__sanitizer_cov_trace_pc
>>>  ; CHECK_PC: call void @__sanitizer_cov_trace_pc
>>>  ; CHECK_PC: call void @__sanitizer_cov_trace_pc
>>> +; CHECK_PC: call void @__sanitizer_cov_trace_pc
>>>  ; CHECK_PC-NOT: call void @__sanitizer_cov_trace_pc
>>>  ; CHECK_PC: ret void
>>>  ; CHECK_PC-NOT: call void @__sanitizer_cov_module_init
>>> @@ -30,6 +31,7 @@ entry:
>>>  ; CHECK_PC_GUARD: call void @__sanitizer_cov_trace_pc_guard
>>>  ; CHECK_PC_GUARD: call void @__sanitizer_cov_trace_pc_guard
>>>  ; CHECK_PC_GUARD: call void @__sanitizer_cov_trace_pc_guard
>>> +; CHECK_PC_GUARD: call void @__sanitizer_cov_trace_pc_guard
>>>  ; CHECK_PC_GUARD-NOT: call void @__sanitizer_cov_trace_pc
>>>  ; CHECK_PC_GUARD: ret void
>>>  ; CHECK_PC_GUARD: call void @__sanitizer_cov_trace_pc_guard_init(i32*
>>> bitcast (i32** @__start___sancov_guards to i32*), i32* bitcast (i32**
>>> @__stop___sancov_guards to i32*))
>>> @@ -38,6 +40,7 @@ entry:
>>>  ; CHECK_PC_GUARD_DARWIN: call void @__sanitizer_cov_trace_pc_guard
>>>  ; CHECK_PC_GUARD_DARWIN: call void @__sanitizer_cov_trace_pc_guard
>>>  ; CHECK_PC_GUARD_DARWIN: call void @__sanitizer_cov_trace_pc_guard
>>> +; CHECK_PC_GUARD_DARWIN: call void @__sanitizer_cov_trace_pc_guard
>>>  ; CHECK_PC_GUARD_DARWIN-NOT: call void @__sanitizer_cov_trace_pc
>>>  ; CHECK_PC_GUARD_DARWIN: ret void
>>>  ; CHECK_PC_GUARD_DARWIN: call void @__sanitizer_cov_trace_pc_guard_init(i32*
>>> bitcast (i32** @"\01section$start$__DATA$__sancov_guards" to i32*),
>>> i32* bitcast (i32** @"\01section$end$__DATA$__sancov_guards" to i32*))
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>>
>>
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170523/836cd1eb/attachment.html>