[PATCH] D33471: [asan] Remove allow_user_segv_handler on Windows.

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 23 16:30:33 PDT 2017


rnk added a comment.

This is unfortunate. I want WinASan to behave as much like Linux ASan as possible. The problem is that the MSVC CRT always registers an unhandled exception filter, so we have to overwrite the "user" segv handler if we want ASan to work properly (i.e. catch null derefs) by default.

Anyway, go for it. All the users that we care about (Chrome) manually install ASan's unhandled exception filter for us, so we don't have to fight over which registration wins: https://cs.chromium.org/chromium/src/third_party/crashpad/crashpad/client/crashpad_client_win.cc?type=cs&q=crashpad+asan+package:%5Echromium$&l=119


https://reviews.llvm.org/D33471





More information about the llvm-commits mailing list