[PATCH] D33236: [PowerPC] Implement vec_xxsldwi builtin.

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 23 13:48:02 PDT 2017


nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

Aside from the minor nit, this LGTM.



================
Comment at: lib/CodeGen/CGBuiltin.cpp:8501
+      // Big endian ElemIdx<N> = Index + N
+      ElemIdx0 = Index + 0;
+      ElemIdx1 = Index + 1;
----------------
Minor nit: no need for the `+ 0`.


https://reviews.llvm.org/D33236





More information about the llvm-commits mailing list