[PATCH] D33420: [LIR] Strengthen the check for recurrence variable in popcnt/CTLZ

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 23 13:46:23 PDT 2017


davide added inline comments.


================
Comment at: lib/Transforms/Scalar/LoopIdiomRecognize.cpp:1140
 
       PHINode *Phi = dyn_cast<PHINode>(Inst->getOperand(0));
       if (!Phi || Phi->getParent() != LoopEntry)
----------------
evstupac wrote:
> Can we reuse the new function here for Inst and Inst->getOperand(0)?
This is NFC, I assume, but we're technically changing the check. If you don't mind, I would do that in a follow-up.


https://reviews.llvm.org/D33420





More information about the llvm-commits mailing list