[PATCH] D33205: ARM] Fix Neon vector type alignment to 64-bit

[Stephen Hines via Phabricator via llvm-commits]

srhines added inline comments.


================
Comment at: lib/Basic/Targets.cpp:5300
 
+    MaxVectorAlign = 64; // 64-bit alignment (AAPCS)
+
----------------
rengolin wrote:
> srhines wrote:
> > This should not be set for Android targets. Doing so would break our existing ABI.
> Regardless of the merits, being practical, I think we should make this condition to the environment, to make sure that at least Android keeps its original alignment.
> 
> Docs updates and future changes to the ABI should be handled separately.
A comment would be good here, and arm-abi-vector.c needs to have rules for checking Android now too. As it stands, there is no test for this code path, which would be bad. I think just keeping the old CHECK's as ANDROID should be fine.


https://reviews.llvm.org/D33205