[PATCH] D33444: Fix an issue of creating symlinks when llvm is embedded
Vassil Vassilev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 23 08:09:00 PDT 2017
v.g.vassilev updated this revision to Diff 99917.
v.g.vassilev added a comment.
Remove extra blank line.
https://reviews.llvm.org/D33444
Files:
cmake/modules/AddLLVM.cmake
Index: cmake/modules/AddLLVM.cmake
===================================================================
--- cmake/modules/AddLLVM.cmake
+++ cmake/modules/AddLLVM.cmake
@@ -200,7 +200,7 @@
# Set each output directory according to ${CMAKE_CONFIGURATION_TYPES}.
# Note: Don't set variables CMAKE_*_OUTPUT_DIRECTORY any more,
-# or a certain builder, for eaxample, msbuild.exe, would be confused.
+# or a certain builder, for example, msbuild.exe, would be confused.
function(set_output_directory target)
cmake_parse_arguments(ARG "" "BINARY_DIR;LIBRARY_DIR" "" ${ARGN})
@@ -1322,7 +1322,7 @@
if(UNIX)
set(dest_binary "$<TARGET_FILE_NAME:${target}>")
endif()
- if(CMAKE_CONFIGURATION_TYPES)
+ if(CMAKE_CONFIGURATION_TYPES AND NOT "${CMAKE_CFG_INTDIR}" STREQUAL ".")
list(GET CMAKE_CONFIGURATION_TYPES 0 first_type)
string(TOUPPER ${first_type} first_type_upper)
set(first_type_suffix _${first_type_upper})
@@ -1335,7 +1335,7 @@
else()
get_target_property(ARG_OUTPUT_DIR ${target} RUNTIME_OUTPUT_DIRECTORY${first_type_suffix})
endif()
- if(CMAKE_CONFIGURATION_TYPES)
+ if(CMAKE_CONFIGURATION_TYPES AND NOT "${CMAKE_CFG_INTDIR}" STREQUAL ".")
string(FIND "${ARG_OUTPUT_DIR}" "/${first_type}/" type_start REVERSE)
string(SUBSTRING "${ARG_OUTPUT_DIR}" 0 ${type_start} path_prefix)
string(SUBSTRING "${ARG_OUTPUT_DIR}" ${type_start} -1 path_suffix)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33444.99917.patch
Type: text/x-patch
Size: 1437 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170523/d88562ae/attachment.bin>
More information about the llvm-commits
mailing list