[PATCH] D33402: [RuntimeDyld, PowerPC] Fix check for external symbols when detecting reloction overflow

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 23 06:20:31 PDT 2017


uweigand updated this revision to Diff 99893.
uweigand added a comment.

Added test case.  Note that it is a bit tricky to replicate the exact condition that triggers the bug in a test case.  The one attached here seems to fail reliably (before the fix) across different operating system versions on Power, but it still makes a few assumptions (called out in the comments).

Note also that no MCJIT or OrcMCJIT tests were actually run on ppc64le at all -- I've had to add the platform name to the supported list in the lit.local.cfg files in those directories ...


https://reviews.llvm.org/D33402

Files:
  lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp
  test/ExecutionEngine/MCJIT/lit.local.cfg
  test/ExecutionEngine/OrcMCJIT/lit.local.cfg
  test/ExecutionEngine/OrcMCJIT/pr32650.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33402.99893.patch
Type: text/x-patch
Size: 4561 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170523/e648c16b/attachment.bin>


More information about the llvm-commits mailing list