[PATCH] D32871: [LV] Using VPlan to model the vectorized code and drive its transformation

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

Some initial comments...



================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:470
 
+public:
   /// A helper function that computes the predicate of the block BB, assuming
----------------
The public protected swap is confusing. I'd create a "protected bubble" and move the methods inside it.


================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:497
+  /// inclusive..
+  void scalarizeInstruction(Instruction *Instr, const VPIteration &Instance,
+                            bool IfPredicateInstr);
----------------
Not virtual anymore? Should it be marked "final"?


https://reviews.llvm.org/D32871