[PATCH] D33418: Support for taking the max of module flags when linking, use for PIE/PIC

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 22 13:48:29 PDT 2017


pcc added inline comments.


================
Comment at: lib/IR/Verifier.cpp:1287
+    Assert(mdconst::dyn_extract_or_null<ConstantInt>(Op->getOperand(2)),
+           "invalid value for 'max' module flag (expected constant integer)",
+           Op->getOperand(2));
----------------
Please add test coverage for this verifier check.


https://reviews.llvm.org/D33418





More information about the llvm-commits mailing list