[PATCH] D33281: [Doc] Update how to install graphviz on macOS

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 22 10:29:52 PDT 2017


dberlin added a comment.

The p



================
Comment at: docs/ProgrammersManual.rst:1291-1295
 with X11, install the `graphviz <http://www.graphviz.org>`_ toolkit, and make
-sure 'dot' and 'gv' are in your path.  If you are running on Mac OS X, download
-and install the Mac OS X `Graphviz program
-<http://www.pixelglow.com/graphviz/>`_ and add
-``/Applications/Graphviz.app/Contents/MacOS/`` (or wherever you install it) to
-your path. The programs need not be present when configuring, building or
-running LLVM and can simply be installed when needed during an active debug
-session.
+sure 'dot' and 'gv' are in your path.  If you are running on macOS, install the
+'graphviz-gui' through `MacPorts <https://www.macports.org>`_. The programs need
+not be present when configuring, building or running LLVM and can simply be
+installed when needed during an active debug session.
----------------
chenwj wrote:
> davide wrote:
> > Why not just removing the link and let people google `install graphviz macos` and pick what's the best solution for them?
> Well, that's usually what people will try first (including me). After trail and error, I found MacPorts would be the easier and feasible one. We can rephrase somehow to say MacPorts is one solution, and there are many others can try if MacPorts fail.
i'm with davide on this one.
THe problem with what you suggest is that when macports now becomes out of date, or whatever, we have to update this again :)

Personally, i used homebrew to install it (and had no issue)
in the past, people used fink (but nobody does anymore).
It'd be nice to not have to worry that our random install instructions will be out of date :)

It's one thing when they are critical to llvm development (which we obviously must keep easy and up to date), but this is pretty secondary, so i think it would probably be better to just tell people "install graphviz" rather than trying to say how to do it .



https://reviews.llvm.org/D33281





More information about the llvm-commits mailing list