[PATCH] D33382: [PartialInlining] introduce an internal option to add partial inlining pass in the pipeline (off by default for now)

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Mon May 22 09:35:36 PDT 2017


On Mon, May 22, 2017 at 9:28 AM, Xinliang David Li <davidxl at google.com> wrote:
>
>
> On Mon, May 22, 2017 at 9:25 AM, Davide Italiano via Phabricator
> <reviews at reviews.llvm.org> wrote:
>>
>> davide accepted this revision.
>> davide added a comment.
>> This revision is now accepted and ready to land.
>>
>> I'm not entirely sure whether you need `cl::ZeroOrMore`. Few comments,
>> with that, LG.
>> Feel free to submit once addressed without another round trip.
>
>
> It allows the option to be specified multiple times on the  command line
> (usually done by build system as ninja).
>

Fair enough. We should consider making the same change to
`-enable-newgvn`. (Note, I never found this being a problem even
though I used ninja, but, who knows).


More information about the llvm-commits mailing list