[PATCH] D33195: [Polly] Add invalidation of the loop SCEVs after merge block generation
Michael Kruse via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 22 07:35:52 PDT 2017
Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.
Hi Baranidharan,
the patch LGTM. An explanation into the doxygen of `invalidateScalarEvolution` about the added code and why it is there (like you explained in the summary) would be nice.
Do you have commit rights? If not, I'd commit for you.
================
Comment at: lib/CodeGen/BlockGenerators.cpp:862
+
+ // Invalidate SCEV of loops surrounding the EscapeUsers
+ for (const auto &EscapeMapping : EscapeMap) {
----------------
Nit: Dot at the end of sentence.
https://reviews.llvm.org/D33195
More information about the llvm-commits
mailing list