[PATCH] D33388: [libcxx] fixup bootstrapping for mingw-w64

[Martell Malone via Phabricator via llvm-commits]

martell marked an inline comment as done.
martell added inline comments.


================
Comment at: libcxx/trunk/lib/CMakeLists.txt:246
   set(STATIC_OUTPUT_NAME "c++")
-  if (WIN32)
+  if (WIN32 AND NOT MINGW)
     set(STATIC_OUTPUT_NAME "libc++")
----------------
chapuni wrote:
> "MSVC" is available.
Yes, We can use `MSVC`

I have a habit of avoiding it because CMAKE is not great in differentiating between the IDE and the compiler but it should work fine here.
I'm hoping more recent versions detect clang tageting msvc not in cl.exe mode picks that up correctly.
Good spot btw.


Repository:
  rL LLVM

https://reviews.llvm.org/D33388