[PATCH] D29892: ar: add llvm-dlltool support

[Martell Malone via Phabricator via llvm-commits]

martell marked 14 inline comments as done.
martell added a comment.

Looking for feedback on how to deal with the change to `ArchiveWriter.cpp` to only impact COFF and not ELF.



================
Comment at: include/llvm/Object/COFFModuleDefinition.h:45
+parseCOFFModuleDefinition(MemoryBufferRef MB, COFF::MachineTypes Machine,
+                          bool MingwDef = false);
 
----------------
ruiu wrote:
> I don't like to add a magical boolean flag to slightly change the existing behavior. Why do you need this? This should be removed unless absolutely necessary.
dlltool's defs are a little different then lib.exe's
specifically mangling, see isDecorated.
and the support for '==' for weak aliasing,
although support for the latter won't hurt lib.exe


Repository:
  rL LLVM

https://reviews.llvm.org/D29892