[PATCH] D33180: Add functionality to cvtres to parse all entries in res file.
Eric Beckmann via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 19 18:59:42 PDT 2017
ecbeckmann added inline comments.
================
Comment at: llvm/include/llvm/Object/WindowsResource.h:59
+ public:
+ ~WindowsResource() override;
+
----------------
ruiu wrote:
> Do you need this?
Yes because the destructor is declared virtual in the base class.
https://reviews.llvm.org/D33180
More information about the llvm-commits
mailing list