[PATCH] D33180: Add functionality to cvtres to parse all entries in res file.
Zachary Turner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 19 17:58:25 PDT 2017
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
lgtm after reflowing the comment.
================
Comment at: llvm/lib/Object/WindowsResource.cpp:83-88
+ HeaderBytes, HeaderSize - 2 * sizeof(uint32_t))); // The data and header
+ // size ints are
+ // themselves part of
+ // the header, so we
+ // must subtract them
+ // from the size.
----------------
Can you move this comment up a line? It looks pretty bad like this.
https://reviews.llvm.org/D33180
More information about the llvm-commits
mailing list