[PATCH] D33355: [IR] Add additional addParamAttr/removeParamAttr to AttributeList API

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

Thanks for working on this!



================
Comment at: include/llvm/IR/Attributes.h:394
   /// attribute sets are immutable, this returns a new set.
   AttributeList addAttribute(LLVMContext &C, ArrayRef<unsigned> Indices,
                              Attribute A) const;
----------------
I'd like to remove this overload now that it is dead within LLVM. You may need to replace it with one that takes a single Index.


================
Comment at: lib/IR/Attributes.cpp:1023
                                           Attribute A) const {
+  // Note: Code-cloned to AttributeList::addParamAttr(C, ArgNos, A). Any edits
+  // here must be mirrored there.
----------------
If we can delete this version, we don't need the comment.


https://reviews.llvm.org/D33355