[PATCH] D33180: Add functionality to cvtres to parse all entries in res file.

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: llvm/lib/Object/WindowsResource.cpp:33-36
+  ArrayRef<uint8_t> Ref(
+      reinterpret_cast<const uint8_t*>(Data.getBufferStart()),
+      Data.getBufferSize());
+  BBS = BinaryByteStream(Ref.drop_front(LeadingSize), support::little);
----------------
My motivation for suggesting the change was ultimately to kill the `reinterpret_cast` which we should avoid wherever possible.  Can we try this?

```
BBS = BinaryByteStream(Data.getBuffer().drop_front(LeadingSize), support::little);
```


https://reviews.llvm.org/D33180