[PATCH] D31266: [sancov] fixing too aggressive instrumentation elimination

[Kostya Serebryany via Phabricator via llvm-commits]

kcc added a comment.

After an offline discussion... 
Looks like me and Vitaly both are busy with other stuff and this thing seems to be blocking you and a few others (and maybe prevents us from finding more bugs). 
So let's just delete the PDOM part as George suggests and then later come up with a better strategy (and a way to test it).

George, want to send a separate CL?

Somewhat unrelated, just want to mention it here: I hope to get to implementing yet another way of coverage instrumentation which will not involve callbacks, just a single increment. 
It's easy to do just that, but I also want to preserve the association bettween the counter and the BB, which is a bit trickier (and requires http://llvm.org/docs/LangRef.html#addresses-of-basic-blocks to work reliably).
This task is orthogonal to the optimization discussed here.


https://reviews.llvm.org/D31266