[llvm] r303383 - [ADT] Fix some Clang-tidy modernize-use-using warnings; other minor fixes (NFC).

[Eugene Zelenko via llvm-commits]

Hi, Adam!

On Thu, May 18, 2017 at 8:12 PM, Adam Nemet <anemet at apple.com> wrote:
> Hi Eugene,
>
> This is causing the modules-enabled macOS build to break with:
>
> lib/Support/LockFileManager.cpp:86:7: error: declaration of 'gethostuuid' must be imported from module 'Darwin.POSIX.unistd' before it is required
>
> I reverted in r303402 while we investigate.
>
> Adam

I think removal of #include "llvm/Support/Compiler.h" from
PointerIntPair.h or PointerSumType.h formally caused build problem.

However, Include What You Use recommend to include
llvm/Config/llvm-config.h (llvm/Support/Compiler.h includes it too)
for LLVM_ON_LINUX (I build on RHEL 6) in LockFileManager.cpp. So most
likely it's proper fix.

If you'll have possibility, could you please verify? It'll be great if
you'll run Include What You Use on MacOS too.

Eugene.