[PATCH] D31266: [sancov] fixing too aggressive instrumentation elimination

George Karpenkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 19 10:59:41 PDT 2017


george.karpenkov added a comment.

> The numbers I remember were like DOM gives 30% saving, PDOM gives 20% more, which is a lot.

But how would we know whether those numbers are good?
E.g. is it saving 20% of unneeded instrumentation, or missing 20% of code which actually needs to be instrumented?
LibFuzzer would find lots of bugs regardless, right?

With programs that large it would be hard to simply look at IR, and check whether instrumentation is spurious.


https://reviews.llvm.org/D31266





More information about the llvm-commits mailing list