[PATCH] D33151: ThinLTO: Verify bitcode before lauching the ThinLTOCodeGenerator.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: include/llvm/Transforms/IPO/FunctionImport.h:58
+  importFunctions(Module &M, const ImportMapTy &ImportList,
+                  Optional<std::function<void(Module &)>> PostProcess = None);
 
----------------
What about renaming `PostProcess` to `PostBitcodeLoading`? It seems more accurate to me.


================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:205
+  Expected<bool> Result =
+      Importer.importFunctions(TheModule, ImportList, {verifyLoadedModule});
   if (!Result) {
----------------
Just curious: are the `{` `}` pair required?


https://reviews.llvm.org/D33151