[PATCH] D33343: Add some tips on how to benchhmark

[Ed Maste via Phabricator via llvm-commits]

emaste added inline comments.


================
Comment at: docs/Benchmarking.rst:14-16
+* Static link. That avoids any variation that might be introduced by
+  loading dynamic libraries. This can be done by passing
+  ``-DLLVM_BUILD_STATIC=ON`` to cmake.
----------------
Should we have a "General" section with this note? Certainly this is true for FreeBSD as well, but it seems like it will apply everywhere.

The advice could also be in a general section, with just the specific commands specific to the OS perhaps. For example, the tmpfs explanation also applies to FreeBSD, and even on other operating systems the general advice is sound. (Actually, the command is also identical on FreeBSD for tmpfs, but probably not elsewhere.)


https://reviews.llvm.org/D33343