[PATCH] D33243: [Atomics][LoopIdiom] Recognize unordered atomic memcpy

[Anna Thomas via Phabricator via llvm-commits]

anna requested changes to this revision.
anna added a comment.
This revision now requires changes to proceed.

Marking as needing changes, based on comments inline.

Daniel, as mentioned in previous comment: it might be better to start off with a refactoring NFC patch which would make the code which uses `isLegaslStore` cleaner. First, instead of bool, return the pattern for which this is valid. Creating an enum would be good - it states clearly which patterns are currently supported. 
The caller of `isLegalStore` collects these stores based on the pattern, but there is no check that exactly one pattern is selected. Also there is an implicit ordering on which pattern is checked. 
Once the NFC is reviewed and checked in, coming back to this patch and cleaning up the booleans and the various checks in `isLegalStore` might be easier.


https://reviews.llvm.org/D33243