[PATCH] D33053: [PowerPC] Implement vec_xxpermdi builtin.
Hiroshi Inoue via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 19 02:16:51 PDT 2017
inouehrs added inline comments.
================
Comment at: test/CodeGen/builtins-ppc-error.c:23
+void testXXPERMDI(void) {
+ int index = 5;
+ vec_xxpermdi(vsi); //expected-error {{too few arguments to function call, expected at least 3, have 1}}
----------------
I am not sure we can assure that clang always do a constant propagation to resolve `index` as a compile time constant. But it seems that an existing test case above already assumes clang does it.
IMO, `const unsigned index = 5;` is a little better.
https://reviews.llvm.org/D33053
More information about the llvm-commits
mailing list