[PATCH] D33240: [Atomics] Rename and change prototype for atomic memcpy intrinsic

[Serguei Katkov via Phabricator via llvm-commits]

skatkov added inline comments.


================
Comment at: include/llvm/IR/IntrinsicInst.h:297
+
+    void setAlignment(Constant *A) { setArgOperand(ARG_ALIGN, A); }
+
----------------
dneilson wrote:
> skatkov wrote:
> > Don't you want to check (or assert) the constraints for the alignment here?
> I figured that's handled by the verifier.
ok, but to me it is one of a primary goal for setter to check incoming args.


================
Comment at: lib/IR/Verifier.cpp:3991
+  case Intrinsic::memcpy_element_unordered_atomic: {
+    ConstantInt *AlignCI = dyn_cast<ConstantInt>(CS.getArgOperand(3));
+    Assert(AlignCI,
----------------
Use getters?


https://reviews.llvm.org/D33240