[PATCH] D33345: [DAG] Mark SPOffset for static allocas attached to stack frame

Nirav Dave via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 18 18:38:22 PDT 2017


niravd created this revision.
Herald added subscribers: javed.absar, nemanjai.

Set object offset for static allocas allocated adjacent to stack
frame. Previously these were all left at zero preventing DAGCombiner
from correctly determining memory aliasing for corresponding
operations (TCO may cause FrameIndices to alias requiring checking the
SPoffset and not just checking the indices themselves).

Many tests indirectly relied on our inability to unalias memory
operations and needed to be modified to preserve their original
intent.


https://reviews.llvm.org/D33345

Files:
  lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  lib/CodeGen/SelectionDAG/FunctionLoweringInfo.cpp
  test/CodeGen/AArch64/arm64-abi-varargs.ll
  test/CodeGen/AArch64/arm64-abi_align.ll
  test/CodeGen/AArch64/arm64-alloca-frame-pointer-offset.ll
  test/CodeGen/AArch64/arm64-vext.ll
  test/CodeGen/AArch64/dag-combine-invaraints.ll
  test/CodeGen/AArch64/swifterror.ll
  test/CodeGen/ARM/atomic-op.ll
  test/CodeGen/Hexagon/convertdptoint.ll
  test/CodeGen/Hexagon/convertdptoll.ll
  test/CodeGen/Hexagon/convertsptoint.ll
  test/CodeGen/Hexagon/convertsptoll.ll
  test/CodeGen/Hexagon/dadd.ll
  test/CodeGen/Hexagon/dmul.ll
  test/CodeGen/Hexagon/doubleconvert-ieee-rnd-near.ll
  test/CodeGen/Hexagon/dsub.ll
  test/CodeGen/Hexagon/fadd.ll
  test/CodeGen/Hexagon/fmul.ll
  test/CodeGen/Hexagon/fsub.ll
  test/CodeGen/MSP430/vararg.ll
  test/CodeGen/PowerPC/complex-return.ll
  test/CodeGen/X86/2011-10-19-widen_vselect.ll
  test/CodeGen/X86/alias-static-alloca.ll
  test/CodeGen/X86/clobber-fi0.ll
  test/CodeGen/X86/hipe-cc.ll
  test/CodeGen/X86/hipe-cc64.ll
  test/CodeGen/X86/legalize-shift-64.ll
  test/CodeGen/X86/machine-outliner-debuginfo.ll
  test/CodeGen/X86/machine-outliner.ll
  test/CodeGen/XCore/varargs.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33345.99516.patch
Type: text/x-patch
Size: 29676 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170519/98203d94/attachment.bin>


More information about the llvm-commits mailing list