[llvm] r303385 - [NewGVN] Replace predicate info leftovers.
Davide Italiano via llvm-commits
llvm-commits at lists.llvm.org
Thu May 18 14:43:23 PDT 2017
Author: davide
Date: Thu May 18 16:43:23 2017
New Revision: 303385
URL: http://llvm.org/viewvc/llvm-project?rev=303385&view=rev
Log:
[NewGVN] Replace predicate info leftovers.
This time with an additional fix, i.e. we remove the dead
@llvm.ssa.copy instruction.
Added:
llvm/trunk/test/Transforms/NewGVN/pr32945.ll
Modified:
llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp
Modified: llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp?rev=303385&r1=303384&r2=303385&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp Thu May 18 16:43:23 2017
@@ -3301,6 +3301,10 @@ bool NewGVN::eliminateInstructions(Funct
Value *DominatingLeader = EliminationStack.back();
+ auto *II = dyn_cast<IntrinsicInst>(DominatingLeader);
+ if (II && II->getIntrinsicID() == Intrinsic::ssa_copy)
+ DominatingLeader = II->getOperand(0);
+
// Don't replace our existing users with ourselves.
if (U->get() == DominatingLeader)
continue;
@@ -3321,6 +3325,8 @@ bool NewGVN::eliminateInstructions(Funct
// It's about to be alive again.
if (LeaderUseCount == 0 && isa<Instruction>(DominatingLeader))
ProbablyDead.erase(cast<Instruction>(DominatingLeader));
+ if (LeaderUseCount == 0 && II)
+ ProbablyDead.insert(II);
++LeaderUseCount;
AnythingReplaced = true;
}
Added: llvm/trunk/test/Transforms/NewGVN/pr32945.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/NewGVN/pr32945.ll?rev=303385&view=auto
==============================================================================
--- llvm/trunk/test/Transforms/NewGVN/pr32945.ll (added)
+++ llvm/trunk/test/Transforms/NewGVN/pr32945.ll Thu May 18 16:43:23 2017
@@ -0,0 +1,24 @@
+; RUN: opt -S -newgvn %s | FileCheck %s
+; CHECK-NOT: call i32 @llvm.ssa.copy
+
+ at d = external global i32
+ at e = external global i32
+define void @tinkywinky() {
+ br i1 true, label %lor.lhs.false, label %cond.true
+lor.lhs.false:
+ %tmp = load i32, i32* @d, align 4
+ %patatino = load i32, i32* null, align 4
+ %or = or i32 %tmp, %patatino
+ store i32 %or, i32* @d, align 4
+ br label %cond.true
+cond.true:
+ %tmp1 = load i32, i32* @e, align 4
+ %tmp2 = load i32, i32* @d, align 4
+ %cmp = icmp eq i32 %tmp1, %tmp2
+ br i1 %cmp, label %cond.true6, label %cond.false
+cond.true6:
+ %cmp7 = icmp slt i32 %tmp1, 0
+ br i1 %cmp7, label %cond.false, label %cond.false
+cond.false:
+ ret void
+}
More information about the llvm-commits
mailing list