[PATCH] D32614: [GVNHoist] Fix: PR32821, add check for anticipability in case of infinite loops

Aditya Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 18 14:37:49 PDT 2017


hiraditya marked an inline comment as done.
hiraditya added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/GVNHoist.cpp:325
+      const BasicBlock *BB = Queue.back();
+      Queue.pop_back();
+      if (WL.count(BB))
----------------
sanjoy wrote:
> This is a shallow drive by comment, but do you have to worry about function calls that throw / infloop here?
That is handled by the function hasEHOnPath called later.


https://reviews.llvm.org/D32614





More information about the llvm-commits mailing list