[PATCH] D24805: [GVNSink] Initial GVNSink prototype
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 18 14:09:26 PDT 2017
efriedma added inline comments.
================
Comment at: lib/Transforms/Scalar/GVNSink.cpp:871
+ return {0, 0};
+ for (auto &N : depth_first(PDT)) {
+ if (!N->getBlock())
----------------
efriedma wrote:
> Could you use `post_order(F)` instead of PDT here? If not, could you add a comment explaining what properties of the post-dominator tree you're depending on?
Err, post_order() isn't right; I guess you want a reverse post-order traversal on the inverted graph, or something like that?
Repository:
rL LLVM
https://reviews.llvm.org/D24805
More information about the llvm-commits
mailing list