[PATCH] D33303: AsmPrinter: mark the beginning and the end of a function in verbose mode

[Matthias Braun via Phabricator via llvm-commits]

MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks!

Please wait a few more days for comments, and if nothing happens commit.



================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:631
 void AsmPrinter::EmitFunctionHeader() {
-  // Print out constants referenced by the function
-  EmitConstantPool();
-
   // Print the 'header' of function.
   const Function *F = MF->getFunction();
----------------
This comment needs to be moved further down now.


================
Comment at: test/CodeGen/AArch64/asm-print-comments.ll:3
+
+; CHECK-LABEL: ; -- Begin function foo
+define hidden i32 @foo() {
----------------
Maybe add an extra `CHECK: foo:` as well? (same for bar)


================
Comment at: utils/abtest.py:29-33
 #    3. First you have to mark begin and end of the functions.
 #       The script comes with some examples called mark_xxx.py.
 #       Unfortunately this is very specific to your environment and it is likely
 #       that you have to write a custom version for your environment.
 #       > for i in before/*.s after/*.s; do mark_xxx.py $i; done
----------------
This section can be removed now.


https://reviews.llvm.org/D33303