[PATCH] D33311: [X86] Match bitcast of vsetcc to pmovmsk

[Elena Demikhovsky via Phabricator via llvm-commits]

delena added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:29020
+  // vxi1 types.
+  if (!LegalTypes && N0.getOpcode() == ISD::SETCC)
+    if (SDValue V = combineBitcastOfSetCC(DAG, SDLoc(N), VT, N0, Subtarget))
----------------
Can you use if (VT.isInteger() && DAG.ComputeNumSignBits(N) == EltBits) ?


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:35127
   case X86ISD::SHRUNKBLEND: return combineSelect(N, DAG, DCI, Subtarget);
-  case ISD::BITCAST:        return combineBitcast(N, DAG, Subtarget);
+  case ISD::BITCAST:        return combineBitcast(N, DAG, Subtarget, !DCI.isBeforeLegalize());
   case X86ISD::CMOV:        return combineCMov(N, DAG, DCI, Subtarget);
----------------
We usually pass DCI to check the phase.


https://reviews.llvm.org/D33311