andrewng added inline comments. ================ Comment at: ELF/Writer.cpp:645 + RF_MIPS_GPREL = 1 << 2, + RF_MIPS_NOT_GOT = 1 << 1 +}; ---------------- Is there a reason why this starts with 1 and not 0? i.e. 1 << 0 https://reviews.llvm.org/D33112