[PATCH] D33180: Add functionality to cvtres to parse all entries in res file.

[David Majnemer via Phabricator via llvm-commits]

majnemer added inline comments.


================
Comment at: llvm/lib/Support/BinaryStreamReader.cpp:14
 #include "llvm/Support/BinaryStreamRef.h"
+#include "llvm/Support/MathExtras.h"
 
----------------
Why is this needed?


================
Comment at: llvm/tools/llvm-cvtres/llvm-cvtres.cpp:125-132
+    if (MachineString == "ARM")
+      Machine = machine::ARM;
+    else if (MachineString == "X64")
+      Machine = machine::X64;
+    else if (MachineString == "X86")
+      Machine = machine::X86;
+    else
----------------
StringSwitch


https://reviews.llvm.org/D33180