[PATCH] D33302: Don't output a PDB unless /DEBUG is specified

[Zachary Turner via Phabricator via llvm-commits]

zturner updated this revision to Diff 99377.
zturner added a comment.

Removed the `/DEBUGPDB` option since it is unreferenced in the code.  If the intent is to force writing a PDB, then all you have to do is specify `/DEBUG`, and you are guaranteed to get a PDB.

Also added some tests confirming the interactions between `/DEBUG` and `/PDB`.

BTW, this page <https://msdn.microsoft.com/en-us/library/kwx19e36.aspx> indicates that it's not just an accident that MSVC linker behaves this way.

> Use /PDB:filename to specify the name of the PDB file. **If /DEBUG is not specified, the /PDB option is ignored**.


https://reviews.llvm.org/D33302

Files:
  lld/COFF/Config.h
  lld/COFF/Driver.cpp
  lld/COFF/Options.td
  lld/COFF/Writer.cpp
  lld/test/COFF/invalid-debug-type.test
  lld/test/COFF/pdb-none.test
  lld/test/COFF/pdb-options.test
  lld/test/COFF/pdb.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33302.99377.patch
Type: text/x-patch
Size: 3989 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170518/f88980fc/attachment.bin>