[PATCH] D33303: AsmPrinter: mark the beginning and the end of a function in verbose mode

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added a comment.

Nice, but I have some nitpicks:



================
Comment at: utils/abtest/abtest.py:14-15
 # Additionally you can perform the same steps with a single .s file. In this
-# mode functions are identified by "# -- Begin FunctionName" and
-# "# -- End FunctionName" markers. The abtest.py then takes all functions from
+# mode functions are identified by "; -- Begin FunctionName" and
+# "; -- End FunctionName" markers. The abtest.py then takes all functions from
 # the file in the "before" directory and replaces one function with the
----------------
Different architecures have different characters for comments. You can try out
  $ grep "CommentString" lib/Target -r
to get some impression of it. Maybe we better change this script to match any line starting with 1 or 2 arbitrary characters followed by " -- Begin ".


https://reviews.llvm.org/D33303