[PATCH] D33279: [JumpThreading] Dont RAUW condition incorrectly

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 17 13:52:39 PDT 2017


reames added inline comments.


================
Comment at: lib/Transforms/Scalar/JumpThreading.cpp:838
+        // exactly one value as returned by LVI. RAUW is incorrect in the
+        // presence of guards and assumes, that have the `Cond` as the use. This
+        // is because of circular logic where the value of `Cond` is calculated
----------------
Er, I don't see why this is a circular logic bug?  I though the problem was that we were using a fact from the end of the block to reason about uses of the value before the assume/guard?


https://reviews.llvm.org/D33279





More information about the llvm-commits mailing list