[PATCH] D33169: [X86] Adding vpopcntd and vpopcntq instructions

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

The test files need some attention.



================
Comment at: test/CodeGen/X86/vector-popcnt-128.ll:8
 ; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx2 | FileCheck %s --check-prefix=ALL --check-prefix=AVX --check-prefix=AVX2
+; RUN: llc < %s -mtriple=x86_64-apple-darwin -mattr=+avx512vpopcntdq | FileCheck %s --check-prefix=AVX512VPOPCNTDQ
 
----------------
Re-generate these files, don't manually edit them.

Keep to the x86_64-unknown-unknown triple


================
Comment at: test/CodeGen/X86/vector-popcnt-256.ll:4
 ; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx2 | FileCheck %s --check-prefix=ALL --check-prefix=AVX --check-prefix=AVX2
+; RUN: llc < %s -mtriple=x86_64-apple-darwin -mattr=+avx512vpopcntdq | FileCheck %s --check-prefix=AVX512VPOPCNTDQ
 
----------------
Re-generate these files, don't manually edit them.

Keep to the x86_64-unknown-unknown triple


================
Comment at: test/CodeGen/X86/vector-popcnt-512.ll:4
 ; RUN: llc < %s -mtriple=x86_64-apple-darwin -mcpu=knl -mattr=+avx512bw | FileCheck %s --check-prefix=ALL --check-prefix=AVX512 --check-prefix=AVX512BW
+; RUN: llc < %s -mtriple=x86_64-apple-darwin -mattr=+avx512vpopcntdq | FileCheck %s --check-prefix=AVX512VPOPCNTDQ
 
----------------
Re-generate these files, don't manually edit them.


================
Comment at: test/CodeGen/X86/vector-popcnt-512.ll:198
+}
+
+define <16 x i32> @test_maskz_vpopcnt_d(i16 %mask, <16 x i32> %a) {
----------------
Don't include mask tests here - full coverage is what the -intrinsics test files are for - please re-add it.


================
Comment at: test/CodeGen/X86/vector-tzcnt-128.ll:10
 ; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx512cd,-avx512vl | FileCheck %s --check-prefix=ALL --check-prefix=AVX --check-prefix=AVX512CD
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx512vpopcntdq | FileCheck %s --check-prefix=ALL --check-prefix=AVX512VPOPCNTDQ
 ;
----------------
Re-generate these files, don't manually edit them.


================
Comment at: test/CodeGen/X86/vector-tzcnt-256.ll:6
 ; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx512cd,-avx512vl | FileCheck %s --check-prefix=ALL --check-prefix=AVX --check-prefix=AVX512CD
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx512vpopcntdq | FileCheck %s --check-prefix=ALL --check-prefix=AVX512VPOPCNTDQ
 ;
----------------
Re-generate these files, don't manually edit them.


================
Comment at: test/CodeGen/X86/vector-tzcnt-512.ll:5
 ; RUN: llc < %s -mtriple=x86_64-apple-darwin -mcpu=knl -mattr=-avx512cd,+avx512bw | FileCheck %s --check-prefix=ALL --check-prefix=AVX512BW
+; RUN: llc < %s -mtriple=x86_64-apple-darwin -mattr=+avx512vpopcntdq | FileCheck %s --check-prefix=ALL --check-prefix=AVX512VPOPCNTDQ
 
----------------
Re-generate these files, don't manually edit them.


Repository:
  rL LLVM

https://reviews.llvm.org/D33169