[llvm] r303272 - Workaround for incorrect Win32 header on GCC.

[Zachary Turner via llvm-commits]

To be honest I haven't checked.  The incorrect definition is here:

https://sourceforge.net/p/mingw-w64/mingw-w64/ci/d43f63b334eac3eaf6ed66f2206fee5eb67064ec/tree/mingw-w64-headers/include/ntstatus.h#l164

You can see that there are unbalanced parentheses in the #define.

I'm not familiar with the MinGW / GCC community, but if it's
straightforward and you point me to the right place and I can submit a bug
report.

On Wed, May 17, 2017 at 11:01 AM İsmail Dönmez <ismail at i10z.com> wrote:

> Hi!
>
> Is there a bug reported for this?
>
> On Wed, May 17, 2017 at 6:39 PM, Zachary Turner via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > Author: zturner
> > Date: Wed May 17 11:39:33 2017
> > New Revision: 303272
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=303272&view=rev
> > Log:
> > Workaround for incorrect Win32 header on GCC.
> >
> > Modified:
> >     llvm/trunk/lib/Support/CrashRecoveryContext.cpp
> >
> > Modified: llvm/trunk/lib/Support/CrashRecoveryContext.cpp
> > URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/CrashRecoveryContext.cpp?rev=303272&r1=303271&r2=303272&view=diff
> >
> ==============================================================================
> > --- llvm/trunk/lib/Support/CrashRecoveryContext.cpp (original)
> > +++ llvm/trunk/lib/Support/CrashRecoveryContext.cpp Wed May 17 11:39:33
> 2017
> > @@ -164,15 +164,13 @@ CrashRecoveryContext::unregisterCleanup(
> >
> >  static LONG CALLBACK ExceptionHandler(PEXCEPTION_POINTERS ExceptionInfo)
> >  {
> > -#ifdef DBG_PRINTEXCEPTION_WIDE_C
> > -  constexpr ULONG WideDbgPrintValue = DBG_PRINTEXCEPTION_WIDE_C;
> > -#else
> > -  constexpr ULONG WideDbgPrintValue = 0x4001000AL;
> > -#endif
> > +  // DBG_PRINTEXCEPTION_WIDE_C is not properly defined on all supported
> > +  // compilers and platforms, so we define it manually.
> > +  constexpr ULONG DbgPrintExceptionWideC = 0x4001000AL;
> >    switch (ExceptionInfo->ExceptionRecord->ExceptionCode)
> >    {
> >    case DBG_PRINTEXCEPTION_C:
> > -  case WideDbgPrintValue:
> > +  case DbgPrintExceptionWideC:
> >    case 0x406D1388:  // set debugger thread name
> >      return EXCEPTION_CONTINUE_EXECUTION;
> >    }
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170517/b76f018d/attachment.html>