[PATCH] D33257: [JumpThreading] Dont RAUW condition if guards in block

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 16 17:23:08 PDT 2017


reames added a comment.

Anna, I believe this is a near duplicate of a patch I posted a while ago and never got around to getting in: https://reviews.llvm.org/D28276.  I'm happy to have you take this to completion, but you might find the code and previous review comments there helpful.

In retrospect, I think I made a mistake in how I approached this.  This is an active bug.  We should remove the replaceAllUsesWith and update the tests as needed.  Only once that's done should we come back and see if we can selectively update in some cases.


https://reviews.llvm.org/D33257





More information about the llvm-commits mailing list