[PATCH] D33151: ThinLTO: Verify bitcode before lauching the ThinLTOCodeGenerator.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

In https://reviews.llvm.org/D33151#756783, @aprantl wrote:

> > This assumes that there exists a main module, which is a foreign concept to ThinLTOCodegenerator till now AFAIK. I'm not sure what you're trying to express here?
> >  Especially, this seems used only in the `codegen`, which is only use in a very specific mode (i.e. split model where you store optimized bitcode and reprocess to perform only the codegen). In such case either you want to verify all the modules that you're about to codegen or none. I have the impression that you'll check only the first one. Not sure if I missed something.
>
> In the attached version I removed the flag. This will cause the
>
> > void ThinLTOCodeGenerator::run() // CodeGenOnly=true
>
> path to verify the module twice. I'm not particularly concerned by this though and it keeps the code simpler.


It seems to me that it indicates that the check in the `codegen()` method is redundant now. Why do we need it? What about just removing it?


https://reviews.llvm.org/D33151